Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Keyword changes #496

Conversation

JR-Morgan
Copy link
Member

Connectors side changes for specklesystems/speckle-sharp-sdk#202

@JR-Morgan JR-Morgan requested a review from clairekuang January 15, 2025 12:20
Copy link

linear bot commented Jan 15, 2025

@JR-Morgan JR-Morgan marked this pull request as draft January 15, 2025 12:20
@JR-Morgan JR-Morgan marked this pull request as ready for review January 15, 2025 20:43
@JR-Morgan JR-Morgan enabled auto-merge (squash) January 15, 2025 20:43
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 9.14%. Comparing base (db4d2f7) to head (614afa6).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...hinoShared/ToHost/Raw/PointCloudToHostConverter.cs 0.00% 6 Missing ⚠️
...ed/ToSpeckle/Raw/NurbsSurfaceToSpeckleConverter.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #496      +/-   ##
========================================
- Coverage   9.15%   9.14%   -0.01%     
========================================
  Files        228     228              
  Lines       4306    4310       +4     
  Branches     542     543       +1     
========================================
  Hits         394     394              
- Misses      3896    3900       +4     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan merged commit f02bf26 into dev Jan 20, 2025
3 checks passed
@JR-Morgan JR-Morgan deleted the jedd/cxpla-154-enforce-nullability-analysers-in-objects-and-use-required branch January 20, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants